refactor: remove any in index.d.ts#325
Merged
Conversation
added 2 commits
October 8, 2024 17:02
DABH
approved these changes
Oct 14, 2024
Contributor
DABH
left a comment
DABH
left a comment
There was a problem hiding this comment.
LGTM. You may want to see if there are any similar issues in winston-transport and winston. Thanks for the contribution!
ghost
deleted the
|
@DABH How long will it take for that commit to be deployed? |
Contributor
|
This has been released in the latest logform/winston-transport/winston versions |
|
This should have been considered a breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TS, the
anytype interferes with normal type inference. It's also potentially dangerous, so I recommend usingunknown. We have changed the typeanyin theindex.d.tsfile tounknownto improve the type stability of the library usage.