Winston 3 compatibility - file creation

[chrismueller]

Please tell us about your environment:

winston version?

• winston@2
• winston@3

What is the problem?

With winston@2 I'm running two file transports. One logging all events and one logging only errors and exceptions. winston@2 is creating the log files when the first log entry is written. winston@3 is creating the log files at initialization even if no log entry is written. It would be nice to have an option to disable the precreation of the log files.

The reason behind is that I'm monitoring my application with checking the existence of the "error" log file.
And now with winston@3 this file is allways created when the application is started,

What's the feature?

Option to disable the precreation of log files

Is this feature similar to an existing feature in another tool?

Like the behave in winston@2

[DABH]

Sure, seems reasonable! I'd be happy to review a PR for this if you're interested/have time, otherwise this is probably just a few-line change so I could look at implementing it in the near future.

[kwiatkk1]

Hi! As you marked this as "good first issue", I've tried to tackle this in #1507.

[Pulkit0729]

Hi, I would like to work on this issue. I have read all the previous comments and looked at the existing PR

[DABH]

Feel free to open a new PR and use code from that old PR — if you address all my comments then we could merge

[Pulkit0729]

@DABH In comment, are you refrencing to DailyRotateFile?

[DABH]

No, the File transport itself supports rotation, that is what I was referring to -- although winsto-daily-rotate-file is very nice :)

[Pulkit0729]

Hey, why is there no documentation for using ratationFormat option in File transport? There is a comment in code saying roation format was broken when combined with max files

[DABH]

I don't know -- that sounds like a problem that arose when rewriting winston 2 to winston 3. It sounds like some new tests should be written, and/or some documentation added :) Unfortunately I haven't looked at the file transport code in a long time -- sorry I can't give more specific advice :(

[Pulkit0729]

#2317
I have crerated a pull request for the issue.
Please review it.

[DABH]

Marking this issue as closed via #2317; will go out in next release