Change interface to class in exported types#2157
Merged
wbt merged 2 commits intowinstonjs:masterfrom Jun 30, 2022
flappyBug:master
Merged
Change interface to class in exported types#2157wbt merged 2 commits intowinstonjs:masterfrom flappyBug:master
wbt merged 2 commits intowinstonjs:masterfrom
flappyBug:master
Conversation
Contributor
Author
|
Can someone help to review this? |
Contributor
|
It seems OK to me, as those types are classes. |
Contributor
Author
|
Ah, you're right. For the style change, it's auto formatted by my IDE. I noticed that and didn't revert that because I saw editorconfig and prettier configured in the project. The formatting just follows those configs. |
Contributor
Author
|
And I think we'd better have style check in CI for better collaboration. But that's out of scope for this PR. |
Contributor
|
Out in 3.8.1. |
This was referenced Aug 24, 2022
Closed
This was referenced May 24, 2024
This was referenced May 31, 2024
This was referenced Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class constructor should be exported as class instead of interface.
Why does this matter? Interface is removed in runtime after compilation. But actually, types like
Loggeris accessible in pure js. For my use case, I'll need a runtime type as a dependency injection token, as well as a well-typed interface.Another reason is class is inheritable, but if one wants to make a class extending interface, he/she should implement all the methods declared in interface.
Ref: https://stackoverflow.com/questions/14345485/whats-the-difference-between-declare-class-and-interface-in-typescript