fix(types): Allow any object to be passed as meta to logger.profile by sokki · Pull Request #2314 · winstonjs/winston

sokki · 2023-06-20T15:28:49Z

It was typed as LogEntry which requires both level and message to be set. That contradicts the implementation that treats these fields as optional.

fixes #1969

DABH · 2023-06-25T00:59:48Z

@sokki , if you merge master into your branch or rebase your PR on master, I think the tests should pass thanks to #2315 . Give it a try and let's see (feel free to @ me so I see the result).

DABH

I approve once CI passes

It was typed as `LogEntry` which requires both `level` and `message` to be set. That contradicts the implementation that treats these fields as optional. fixes winstonjs#1969

sokki · 2023-06-26T07:06:44Z

@DABH I rebased onto master. CI needs manual approval to run.

DABH approved these changes Jun 25, 2023

View reviewed changes

fix(types): Allow any object to be passed as meta to logger.profile

5c3f3ba

It was typed as `LogEntry` which requires both `level` and `message` to be set. That contradicts the implementation that treats these fields as optional. fixes winstonjs#1969

sokki force-pushed the patch-1 branch from 89e4a46 to 5c3f3ba Compare June 26, 2023 07:03

DABH merged commit 9d6001a into winstonjs:master Jun 28, 2023

cvs-ops mentioned this pull request May 24, 2024

[Snyk] Upgrade winston from 3.8.1 to 3.13.0 dvsa/cvs-svc-enquiry#86

Open

rish2497 mentioned this pull request May 24, 2024

[Snyk] Upgrade winston from 3.6.0 to 3.13.0 i3-Market-V3-Public-Repository/SP3-SSIAM-NodeOidcProvider#179

Open

This was referenced May 24, 2024

[Snyk] Upgrade winston from 3.8.0 to 3.13.0 FlorentinTh/LE2ML-Windowing-Module#350

Open

[Snyk] Upgrade winston from 3.8.0 to 3.13.0 FlorentinTh/LE2ML-FeatureExtractor-Module#347

Open

karlclement mentioned this pull request May 25, 2024

[Snyk] Upgrade winston from 3.7.2 to 3.13.0 SquireAI/echolayer-api#563

Closed

rish2497 mentioned this pull request May 25, 2024

[Snyk] Upgrade winston from 3.6.0 to 3.13.0 i3-Market-V3-Public-Repository/SP3-SSIAM-VerifiableCredentials#56

Open

nc-minh mentioned this pull request May 25, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.13.0 openuniland/docvault-be#359

Open

cvs-ops mentioned this pull request May 25, 2024

[Snyk] Upgrade winston from 3.7.2 to 3.13.0 dvsa/cvs-tsk-transform-tech-records#28

Open

slatersnyk mentioned this pull request May 25, 2024

[Snyk] Upgrade winston from 3.4.0 to 3.13.0 slatersnyk/juice-shop#674

Open

fanibahar mentioned this pull request May 25, 2024

[Snyk] Upgrade winston from 3.4.0 to 3.13.0 fanibahar/juice-shop1#67

Open

paladinmansouri mentioned this pull request May 26, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.13.0 paladinmansouri/node-js-sample-logging#21

Open

cooldev-200 mentioned this pull request May 26, 2024

[Snyk] Upgrade winston from 3.4.0 to 3.13.0 cooldev-200/juice-shop#140

Open

drwho725 mentioned this pull request May 26, 2024

[Snyk] Upgrade winston from 3.2.1 to 3.13.0 drwho725/slack-link-unfurling#25

Closed

This was referenced May 26, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.13.0 nejidevelops/Serveless-Application#32

Open

[Snyk] Upgrade winston from 3.8.2 to 3.13.0 nejidevelops/Serveless-Application#35

Open

AnushaSalian mentioned this pull request May 30, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.13.0 virtual-labs/ph3-lab-mgmt#447

Open

karlclement mentioned this pull request May 31, 2024

[Snyk] Upgrade winston from 3.7.2 to 3.13.0 SquireAI/echolayer-api#592

Closed

nejidevelops mentioned this pull request Jun 1, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.13.0 nejidevelops/Serveless-Application#37

Open

karlclement mentioned this pull request Jun 4, 2024

[Snyk] Upgrade winston from 3.7.2 to 3.13.0 SquireAI/echolayer-api#602

Closed

This was referenced Sep 29, 2024

[Snyk] Upgrade winston from 3.10.0 to 3.14.2 JerryJ1964/bed-final-project-boilerplate#2

Open

[Snyk] Upgrade winston from 3.9.0 to 3.14.2 JerryJ1964/desktop-tutorial#3

Open

tahmid198 mentioned this pull request Sep 30, 2024

[Snyk] Upgrade winston from 3.4.0 to 3.14.2 tahmid198/juice-shop#3

Open

AnushaSalian mentioned this pull request Oct 8, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.14.2 virtual-labs/ph3-lab-mgmt#552

Open

nejidevelops mentioned this pull request Oct 27, 2024

[Snyk] Upgrade winston from 3.2.1 to 3.15.0 nejidevelops/cloud-developer#452

Open

rish2497 mentioned this pull request Oct 27, 2024

[Snyk] Upgrade winston from 3.6.0 to 3.15.0 i3-Market-V3-Public-Repository/SP3-SSIAM-NodeOidcProvider#230

Open

nejidevelops mentioned this pull request Oct 27, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.15.0 nejidevelops/Serveless-Application#133

Open

fanibahar mentioned this pull request Oct 29, 2024

[Snyk] Upgrade winston from 3.4.0 to 3.15.0 fanibahar/juice-shop1#112

Open

m-heyda mentioned this pull request Oct 31, 2024

[Snyk] Upgrade winston from 3.3.0 to 3.15.0 m-heyda/hain#40

Open

paladinmansouri mentioned this pull request Oct 31, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.15.0 paladinmansouri/node-js-sample-logging#34

Open

BenjaminHoegh mentioned this pull request Oct 31, 2024

[Snyk] Upgrade winston from 3.2.1 to 3.15.0 BenjaminHoegh/dbml#11

Closed

This was referenced Nov 1, 2024

[Snyk] Upgrade winston from 3.8.0 to 3.15.0 FlorentinTh/LE2ML-Windowing-Module#362

Open

[Snyk] Upgrade winston from 3.8.0 to 3.15.0 FlorentinTh/LE2ML-FeatureExtractor-Module#360

Open

drnachio mentioned this pull request Nov 2, 2024

[Snyk] Upgrade winston from 3.3.3 to 3.15.0 acttoreact/watcher#963

Open

debarghyab mentioned this pull request Nov 3, 2024

[Snyk] Upgrade winston from 3.2.1 to 3.15.0 debarghyab/rabbitmq-logger#848

Open

nejidevelops mentioned this pull request Nov 4, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.15.0 nejidevelops/Serveless-Application#135

Open

Dmitry-White mentioned this pull request Nov 5, 2024

[Snyk] Upgrade winston from 3.10.0 to 3.15.0 Dmitry-White/Node.js-Playground#1209

Open

AnushaSalian mentioned this pull request Nov 5, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.15.0 virtual-labs/ph3-lab-mgmt#559

Open

cksachdev mentioned this pull request Nov 7, 2024

[Snyk] Upgrade winston from 3.10.0 to 3.15.0 adaptlearning/adapt_authoring#2799

Closed

nejidevelops mentioned this pull request Nov 11, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.15.0 nejidevelops/Serveless-Application#137

Open

nickvadala-snyk mentioned this pull request Nov 11, 2024

[Snyk] Upgrade winston from 3.4.0 to 3.15.0 nickvadala-snyk/juice-shop#2

Open

rish2497 mentioned this pull request Nov 11, 2024

[Snyk] Upgrade winston from 3.6.0 to 3.15.0 i3-Market-V3-Public-Repository/SP3-SSIAM-NodeOidcProvider#234

Open

fanibahar mentioned this pull request Nov 12, 2024

[Snyk] Upgrade winston from 3.4.0 to 3.15.0 fanibahar/juice-shop1#120

Open

Dmitry-White mentioned this pull request Nov 12, 2024

[Snyk] Upgrade winston from 3.10.0 to 3.15.0 Dmitry-White/Node.js-Playground#1211

Open

paladinmansouri mentioned this pull request Nov 13, 2024

[Snyk] Upgrade winston from 3.8.2 to 3.15.0 paladinmansouri/node-js-sample-logging#37

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(types): Allow any object to be passed as meta to logger.profile#2314

fix(types): Allow any object to be passed as meta to logger.profile#2314
DABH merged 1 commit intowinstonjs:masterfrom
sokki:patch-1

sokki commented Jun 20, 2023

Uh oh!

DABH commented Jun 25, 2023

Uh oh!

DABH left a comment

Uh oh!

sokki commented Jun 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sokki commented Jun 20, 2023

Uh oh!

DABH commented Jun 25, 2023

Uh oh!

DABH left a comment

Choose a reason for hiding this comment

Uh oh!

sokki commented Jun 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants