Skip to content

Add syntax highlighting to code snippets.#16

Merged
bschwartz merged 1 commit intowistia:masterfrom
joshuapinter:patch-1
Dec 29, 2014
Merged

Add syntax highlighting to code snippets.#16
bschwartz merged 1 commit intowistia:masterfrom
joshuapinter:patch-1

Conversation

@joshuapinter
Copy link
Copy Markdown
Contributor

Makes the README much cleaner and easier to read.

It's too bad that Github doesn't do this by default because I prefer the code separation with the four space indents but there ya go.

Makes the README much cleaner and easier to read.

It's too bad that Github doesn't do this by default because I prefer the code separation with the four space indents but there ya go.
@bschwartz
Copy link
Copy Markdown
Member

Oh, yes! This is awesome. Thanks for much for this, Joshua!

bschwartz added a commit that referenced this pull request Dec 29, 2014
Add syntax highlighting to code snippets.
@bschwartz bschwartz merged commit c7e65ce into wistia:master Dec 29, 2014
@joshuapinter
Copy link
Copy Markdown
Contributor Author

👍

Quick question. Was there a reason why you guys didn't include the upload functionality in this gem and, instead, made a ruby command line gem for it?

@joshuapinter joshuapinter deleted the patch-1 branch December 29, 2014 03:26
@joshuapinter
Copy link
Copy Markdown
Contributor Author

Another quick question while I have you, @bschwartz: Is the Wistia-Uploader gem intended only to be used for command line uploads to Wistia. I.e. Not to be integrated into a Rails app?

Thanks!

@bschwartz
Copy link
Copy Markdown
Member

Hey Joshua, we have some updates planned for this gem and will likely include upload functionality. I wouldn't use the wistia-uploader gem in a Rails app. You should do something like this: http://wistia.com/doc/upload-api#example_code. Hope that makes sense!

@joshuapinter
Copy link
Copy Markdown
Contributor Author

Thanks for the response, @bschwartz. I ended up doing something similar to what you suggested but borrowing some implementation from the wistia-uploader gem for importing remote files from S3.

Knowing that you have some updates planned to the wistia-api gem is good to hear. In that case, I'll keep the PRs coming for anything valuable.

Keep it up! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants