Conversation
🦋 Changeset detectedLatest commit: 5759873 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
| 📦 Package | 🔒 Before | 🔓 After |
|---|---|---|
| @cloudflare/unenv-preset | trusted-with-provenance | none |
| workerd | trusted-with-provenance | none |
| undici | provenance | none |
| miniflare | trusted-with-provenance | none |
| youch | provenance | none |
| @cloudflare/workerd-darwin-64 | trusted-with-provenance | none |
| @cloudflare/workerd-darwin-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-windows-64 | trusted-with-provenance | none |
| wrangler | trusted-with-provenance | none |
Member
florian-lefebvre
left a comment
There was a problem hiding this comment.
Should we review all our virtual modules names? I think we have some for eg. react options
Member
Author
Sure, but not in this PR |
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
matthewp
reviewed
Dec 18, 2025
matthewp
approved these changes
Dec 18, 2025
Contributor
matthewp
left a comment
There was a problem hiding this comment.
just the one question about pinning the astro version in the blog example, otherwise lgtm
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
AstroDevPipelinetoRunnablePipeline, as an analogy of the vite runnable dev environmentDevApptoNonRunnablePipeline, as an analogy of the vite non-runnable dev environmenthandleRoutefromAstroServerApp, and usesrenderinstead (reduced code branching)virtual:astro:*nomenclature. This fixes it because the Cloudflare adapter pre-bundles all virtual l modules that start withvirtual:astro:*Testing
CI should stay green
Docs
N/A