Skip to content

fix: cloudflare and dev app#15045

Merged
ematipico merged 8 commits intonextfrom
fix/vue-and-server-app
Dec 18, 2025
Merged

fix: cloudflare and dev app#15045
ematipico merged 8 commits intonextfrom
fix/vue-and-server-app

Conversation

@ematipico
Copy link
Member

Changes

  • Renames AstroDevPipeline to RunnablePipeline, as an analogy of the vite runnable dev environment
  • Renames DevApp to NonRunnablePipeline, as an analogy of the vite non-runnable dev environment
  • Removes handleRoute from AstroServerApp, and uses render instead (reduced code branching)
  • Fixes the Cloudflare + Vue bug, by renaming the virtual module to use our internal virtual:astro:* nomenclature. This fixes it because the Cloudflare adapter pre-bundles all virtual l modules that start with virtual:astro:*

Testing

CI should stay green

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025

🦋 Changeset detected

Latest commit: 5759873

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Dec 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 17, 2025

⚠️ Package Trust Level Decreased

Caution

Decreased trust levels may indicate a higher risk of supply chain attacks. Please review these changes carefully.

📦 Package 🔒 Before 🔓 After
@cloudflare/unenv-preset trusted-with-provenance none
workerd trusted-with-provenance none
undici provenance none
miniflare trusted-with-provenance none
youch provenance none
@cloudflare/workerd-darwin-64 trusted-with-provenance none
@cloudflare/workerd-darwin-arm64 trusted-with-provenance none
@cloudflare/workerd-linux-64 trusted-with-provenance none
@cloudflare/workerd-linux-arm64 trusted-with-provenance none
@cloudflare/workerd-windows-64 trusted-with-provenance none
wrangler trusted-with-provenance none

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we review all our virtual modules names? I think we have some for eg. react options

@ematipico
Copy link
Member Author

Should we review all our virtual modules names? I think we have some for eg. react options

Sure, but not in this PR

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass, LGTM

ematipico and others added 2 commits December 18, 2025 13:56
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one question about pinning the astro version in the blog example, otherwise lgtm

@ematipico ematipico merged commit 31074fc into next Dec 18, 2025
6 checks passed
@github-actions github-actions bot removed the pkg: example Related to an example package (scope) label Dec 18, 2025
@ematipico ematipico deleted the fix/vue-and-server-app branch December 18, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: vue Related to Vue (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants