fix(astro): Queue concurrent writeToDisk calls#15454
Merged
Conversation
🦋 Changeset detectedLatest commit: f885239 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
ematipico
approved these changes
Feb 10, 2026
florian-lefebvre
approved these changes
Feb 10, 2026
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When multiple
store.set()calls triggered overlapping writes, the second write could be silently dropped because#writeFileAtomicretried with stale serialized data. Writes are now queued at thewriteToDisk()level so that each write re-serializes fresh data.Testing
There is a new unit test reproducing the scenario and validating the correct behavior.
Docs
No change is needed in docs.