fix(cloudflare): image transform ignoring quality parameter#15843
Merged
Princesseuh merged 2 commits intowithastro:mainfrom Mar 11, 2026
Merged
fix(cloudflare): image transform ignoring quality parameter#15843Princesseuh merged 2 commits intowithastro:mainfrom
Princesseuh merged 2 commits intowithastro:mainfrom
Conversation
add qualityTable
github-actions
bot
added
the
pkg: integration
🦋 Changeset detectedLatest commit: 946a559 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
imageService: 'cloudflare-binding'ignores theqsearch param, this PR fixes that. thequalityTableis from@astrojs/vercelastro/packages/integrations/vercel/src/image/shared.ts
Line 56 in a7cc437
Testing
pnpm run testin packages/integrations/cloudflare/I tried to add a test locally but the local workerd doesn't actually change the image quality when passing in the quality field. It returned two files with identical hashes when I pass in two different quality values. I can confirm that the quality does indeed change on cloudflare.
Docs
bug fix doesn't need doc change