You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem was that when the settings page loaded, the "2D Configuration" button appeared a few milliseconds later than the other buttons. This meant that sometimes you would accidentally make incorrect input. If you were fast and wanted to press a button quickly, the button would appear just before you pressed it, causing the rest of the buttons to move as well, and you would press the wrong button.
Actually, I'm on your side, but in this case I would do it this way because of the following reasons:
We have two macros: WLED_DISABLE_2D and WLED_ENABLE_DMX. For me it is more logical when you disable something that it then gets hidden and when you enable something that it then gets visible. And since 2D is enabled by default, I would leave it visible by default.
It doesn't look so nice if the settings page has to build up first and is not completely loaded immediately.
The much more important reason is that if you click through the menu too fast, you may misclick more easily, since button is displayed only after about 20ms. For example, if you want to go to Time & Updates and you need 15ms to place the mouse cursor on the Time & Updates button, then just before you left-click, 2D Configuration may appear and you may misclick. I think on mobile devices with touch display it is even more likely to misclick.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that when the settings page loaded, the "2D Configuration" button appeared a few milliseconds later than the other buttons. This meant that sometimes you would accidentally make incorrect input. If you were fast and wanted to press a button quickly, the button would appear just before you pressed it, causing the rest of the buttons to move as well, and you would press the wrong button.