Usermod BME68X Sensor Implementation rebased for WLED 0.15#3994
Merged
Usermod BME68X Sensor Implementation rebased for WLED 0.15#3994
Conversation
OTA_PASS
…n WLED 0.15" This reverts commit faa2fba.
blazoncek
suggested changes
May 20, 2024
Contributor
blazoncek
left a comment
blazoncek
left a comment
There was a problem hiding this comment.
Thanks. Well written and complete. But...
There's a code that does not belong in a usermod PR. You might re-open the original PR for that instead.
| #define WLED_AP_PASS DEFAULT_AP_PASS | ||
| #endif | ||
|
|
||
| #ifndef OTA_PASS |
Contributor
Author
There was a problem hiding this comment.
Oops. Sorry about that. Somehow I'm too dumb to make various pull requests. :-D
Accidentally included changes removed.
blazoncek
approved these changes
May 21, 2024
One error message was in German
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is again my pull request for the user mod "BMW68X" sensor implementation. Now as requested for wled version 0.15.