Skip to content

Add apple-touch-icon Link Tag#4577

Merged
netmindz merged 2 commits intowled:mainfrom
DevJogger:main
Mar 11, 2025
Merged

Add apple-touch-icon Link Tag#4577
netmindz merged 2 commits intowled:mainfrom
DevJogger:main

Conversation

@DevJogger
Copy link
Copy Markdown
Contributor

@DevJogger DevJogger commented Feb 27, 2025 •
edited by coderabbitai Bot
Loading

This PR adds a link tag with rel="apple-touch-icon" to index.htm, specifying the icon displayed when the webpage is added to the home screen from Safari on iOS.

Reason for Change

When a user adds a webpage to their home screen using Safari’s “Add to Home Screen” feature, Safari generates an icon automatically if no apple-touch-icon is specified. However, the default generated icon may not provide the best visual experience. By explicitly defining the apple-touch-icon, the shortcut will look more like a native app, ensuring a more polished and consistent user experience.

Impact

  • Affects only iOS Safari’s home screen icon appearance.
  • No impact on other browsers or platforms.

Please review and let me know if any adjustments are needed. Thanks!

Screenshot

photo_2025-02-27_14-57-31

Summary by CodeRabbit

  • New Features
    • Enhanced compatibility with Apple devices by adding an Apple Touch Icon. Now, when users add the web app to their home screen on an Apple device, a custom icon is displayed to improve the overall appearance.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 27, 2025 •
edited
Loading

Walkthrough

The change is confined to an HTML file where a single new line was added in the <head> section. This new line inserts a <link> element with the attribute rel="apple-touch-icon" and a base64 encoded PNG specified as the href. The existing content and structure of the HTML document remain unchanged.

Changes

File Change Summary
wled00/.../index.htm Added a new <link rel="apple-touch-icon" href="data:image/png;base64,..."> entry in the <head> section to specify an Apple icon.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d07a057 and c9b8789.

📒 Files selected for processing (1)
  • wled00/data/index.htm (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • wled00/data/index.htm

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@blazoncek
Copy link
Copy Markdown
Contributor

blazoncek commented Feb 28, 2025

Please reduce the image size.

@DevJogger
Copy link
Copy Markdown
Contributor Author

DevJogger commented Feb 28, 2025

Please reduce the image size.

Reduced the image size, please check the latest code. Thanks!

@netmindz netmindz merged commit 8bee304 into wled:main Mar 11, 2025
@netmindz
Copy link
Copy Markdown
Member

netmindz commented Mar 11, 2025

Thanks for your PR

@DevJogger
Copy link
Copy Markdown
Contributor Author

DevJogger commented Mar 11, 2025

Thanks for your PR

Thank you! Happy to help

softhack007 pushed a commit to MoonModules/WLED-MM that referenced this pull request Jan 17, 2026
@netmindz @softhack007
Merge pull request wled#4577 from DevJogger/main
2b543f2 
Add apple-touch-icon Link Tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DevJogger @blazoncek @netmindz