set unused segments to black#5192
Conversation
0.15.1 introduced a new behaviour on how "empty space" is treated. while it is technically correct, it is not user friendly and is a breaking change: all previous versions behaved differently and so does 0.16.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
softhack007
left a comment
There was a problem hiding this comment.
looks reasonable. I agree its better to set the previous segment to "black", so to avoid orphaned pixels that stay on the LEDs until the bus driver gets re-initialized.
0.15.1 introduced a new behaviour on how "empty space" is treated. While it is technically correct, it is not user friendly and is a breaking change: all previous versions behaved differently and so does 0.16.
What this change does is to set any unused pixels to black instead of keeping the last value.