move pixelforge json list and cpt city custom palette selection to wled repo#5541
move pixelforge json list and cpt city custom palette selection to wled repo#5541
Conversation
also removed commented code
WalkthroughUpdates external resource fetch URLs in two palette and tool editor files, replacing the prior host endpoint with a new centralized host. Removes dead commented code and clarifies an existing comment in the affected files. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
wled00/data/cpal/cpal.htm (1)
8-8: Consider separating whitespace cleanup from functional changes in future PRs.This line contains a minor whitespace change within the commented HTML block. While the impact here is minimal, the project prefers whitespace-only edits to be submitted in dedicated PRs to keep functional changes clear and simplify commit cherry-picking. Based on learnings: In the WLED repository, trailing-whitespace removals or other pure-whitespace "optimizations" must NOT be intermixed with real code/logic changes in the same PR, as it makes diffs harder to read and causes trouble when cherry-picking commits.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@wled00/data/cpal/cpal.htm` at line 8, The change is a whitespace-only edit inside the commented HTML block around the script tag <script src="iro.js"></script>; revert this whitespace-only modification from the current commit and move it into a separate PR dedicated to formatting/trailing-whitespace cleanup so that this PR contains only functional changes, or alternatively remove the whitespace change from the diff (restore original comment text) and re-apply formatting in an isolated commit/PR for easier review and cherry-picking.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@wled00/data/cpal/cpal.htm`:
- Line 8: The change is a whitespace-only edit inside the commented HTML block
around the script tag <script src="iro.js"></script>; revert this
whitespace-only modification from the current commit and move it into a separate
PR dedicated to formatting/trailing-whitespace cleanup so that this PR contains
only functional changes, or alternatively remove the whitespace change from the
diff (restore original comment text) and re-apply formatting in an isolated
commit/PR for easier review and cherry-picking.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 69fe03b5-4e15-4d6c-bbde-5ce3b5fc0dcf
📒 Files selected for processing (2)
wled00/data/cpal/cpal.htmwled00/data/pixelforge/pixelforge.htm
Summary by CodeRabbit