Skip to content

move pixelforge json list and cpt city custom palette selection to wled repo#5541

Merged
DedeHai merged 1 commit intowled:mainfrom
DedeHai:move_jsons
Apr 26, 2026
Merged

move pixelforge json list and cpt city custom palette selection to wled repo#5541
DedeHai merged 1 commit intowled:mainfrom
DedeHai:move_jsons

Conversation

@DedeHai
Copy link
Copy Markdown
Collaborator

@DedeHai DedeHai commented Apr 26, 2026

Summary by CodeRabbit

  • Chores
    • Updated external resource fetching endpoints to new host location for palette and tool data.
    • Removed commented-out legacy code.
    • Refined inline documentation for clarity.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

Walkthrough

Updates external resource fetch URLs in two palette and tool editor files, replacing the prior host endpoint with a new centralized host. Removes dead commented code and clarifies an existing comment in the affected files.

Changes

Cohort / File(s) Summary
Palette editor cleanup
wled00/data/cpal/cpal.htm
Updates fetchExt() to download external palette JSON from wled.github.io/wled-web-tools instead of dedehai.github.io. Removes commented-out rndPal function block and cleans up whitespace.
Pixel Forge tool fetch update
wled00/data/pixelforge/pixelforge.htm
Changes remoteURL to fetch pftools.json from wled.github.io/wled-web-tools instead of dedehai.github.io. Clarifies comment noting image effect ID 53 in curImgSeg().

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • netmindz
  • softhack007
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: moving pixelforge JSON list and cpt city palette selection from external hosts (dedehai.github.io) to the WLED repository (wled.github.io/wled-web-tools).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
wled00/data/cpal/cpal.htm (1)

8-8: Consider separating whitespace cleanup from functional changes in future PRs.

This line contains a minor whitespace change within the commented HTML block. While the impact here is minimal, the project prefers whitespace-only edits to be submitted in dedicated PRs to keep functional changes clear and simplify commit cherry-picking. Based on learnings: In the WLED repository, trailing-whitespace removals or other pure-whitespace "optimizations" must NOT be intermixed with real code/logic changes in the same PR, as it makes diffs harder to read and causes trouble when cherry-picking commits.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@wled00/data/cpal/cpal.htm` at line 8, The change is a whitespace-only edit
inside the commented HTML block around the script tag <script
src="iro.js"></script>; revert this whitespace-only modification from the
current commit and move it into a separate PR dedicated to
formatting/trailing-whitespace cleanup so that this PR contains only functional
changes, or alternatively remove the whitespace change from the diff (restore
original comment text) and re-apply formatting in an isolated commit/PR for
easier review and cherry-picking.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@wled00/data/cpal/cpal.htm`:
- Line 8: The change is a whitespace-only edit inside the commented HTML block
around the script tag <script src="iro.js"></script>; revert this
whitespace-only modification from the current commit and move it into a separate
PR dedicated to formatting/trailing-whitespace cleanup so that this PR contains
only functional changes, or alternatively remove the whitespace change from the
diff (restore original comment text) and re-apply formatting in an isolated
commit/PR for easier review and cherry-picking.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 69fe03b5-4e15-4d6c-bbde-5ce3b5fc0dcf

📥 Commits

Reviewing files that changed from the base of the PR and between f4f4978 and 846b40a.

📒 Files selected for processing (2)
  • wled00/data/cpal/cpal.htm
  • wled00/data/pixelforge/pixelforge.htm

@DedeHai DedeHai merged commit 02e593d into wled:main Apr 26, 2026
25 checks passed
DedeHai added a commit that referenced this pull request Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant