Fix UEIPAddressPoolIdentity to use 2-byte length field#141
Open
bjosv wants to merge 1 commit intowmnsk:mainfrom
Open
Fix UEIPAddressPoolIdentity to use 2-byte length field#141bjosv wants to merge 1 commit intowmnsk:mainfrom
bjosv wants to merge 1 commit intowmnsk:mainfrom
Conversation
The UE IP Address Pool Identity IE (type 177) encoded the identity length as 1 byte, but TS 29.244 8.2.128 defines it as 2 bytes. The spec has always used 2 bytes since the IE was introduced. Updated all test accordingly. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
UE IP Address Pool IdentityIE (type 177) previously encoded the identity length as 1 byte,but TS 29.244 - 8.2.128 defines it as 2 bytes and has since the IE was introduced.
Updated the UE IP address Pool Identity Length to 2 bytes (octets 5-6), and all tests accordingly.