Merge ZoneEvent and GpuEvent (redo)#1166
Merge ZoneEvent and GpuEvent (redo)#1166erieaton-amd wants to merge 5 commits intowolfpld:masterfrom
Conversation
This replaces the GpuEvent struct with ZoneEvent and a GpuExtra data type. This allows some common code to be merged, but since this is a minimal implementation of the idea, only a few small things are merged by this patch.
|
How are GPU zone colors determined? With CPU zones thread id is used as a base for the color. What differentiates different GPU tracks? |
b923816 to
08bfd9a
Compare
I realized there was an issue that was making the GPU zones always purple. I've posted a small change that makes the GPU zones' color match the CPU thread that is making the GPU calls. |
The function GetZoneCtx isn't needed. This patch introduces a small structure to help transport the context around to avoid the expensive search. The GPU timeline function take the context as a parameter now instead of the thread ID, since the supplied thread ID is derived from the context in every invocation.
This change has CPU and GPU use the same code to calculate zone colors. This changes the UI because the GPU zones will have a different color. The color of GPU zones will be set to match the CPU thread making the GPU calls.
5a0855b to
8bfc6ad
Compare
|
The whole Given that you have made If the above is true, there is no need to construct the wrapper/adapter struct, as the GPU data can be accessed via the extra pointer, and I think it should be possible for the code to know which Does that make sense? |
This PR accomplishes part of what #1155 does with fewer changes.
The work is split across three changes:
Overall notes: