Fix tracy deadlock on WaitForSingleObject when unloading within DLLMain#1308
Open
ivan-flink wants to merge 1 commit intowolfpld:masterfrom
Open
Fix tracy deadlock on WaitForSingleObject when unloading within DLLMain#1308ivan-flink wants to merge 1 commit intowolfpld:masterfrom
ivan-flink wants to merge 1 commit intowolfpld:masterfrom
Conversation
0ec9bf1 to
40bddad
Compare
According to Microsoft official guidelines, synchronize with other threads within DLLMain is forbidden because it can cause a deadlock.
Author
|
@wolfpld could you please re-run linux job, because the error related to the runner, not the change itself [build](https://github.com/wolfpld/tracy/actions/runs/23254744136/job/67616969586)
The hosted runner lost communication with the server. Anything in your workflow that terminates the runner process, starves it for CPU/Memory, or blocks its network access can cause this error. |
Owner
It will keep failing. Ignore it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #349
According to Microsoft official guidelines, synchronize with other threads within DLLMain is forbidden because it can cause a deadlock.
https://learn.microsoft.com/en-us/windows/win32/dlls/dynamic-link-library-best-practices