solana: Remove *_multisig instruction variants#593
Merged
Conversation
Contributor
Author
|
As this PR introduces breaking changes to |
nonergodic
approved these changes
Mar 6, 2025
Contributor
|
Btw, I like the streamlining of integrating the multisig handling in the respective instructions instead of doing the ix multiplexing 👍 |
…ount in `ReleaseInboundMint`
There are a few suspicious aspects of the inbox release logic: 1. `release_inbound_unlock` takes a flag that determines whether a `false` result from `try_release` should cause an error. The flag indicates that it should revert on delay. However, `try_release` can also return `false` when a transaction has not been approved. If the flag is set, the transaction will not return an error when a user tries to release a transaction that is not approved even though whether a transaction is approved has nothing to do with its expected behaviour when it is delayed 2. The custom error TransferNotApproved is defined but unused Taken together, I believe `try_release()` should revert with the TransferNotApproved error. This would disambiguate the various 'false' results and provide more intuitive behaviour when a user tries to release a transaction that is not approved.
nvsriram
force-pushed
the
solana/remove-multisig-variants
branch
from
060499f to
cc573c3
Compare
nik-suri
approved these changes
Mar 25, 2025
Contributor
nik-suri
left a comment
nik-suri
left a comment
There was a problem hiding this comment.
Stamping this PR to unblock merge. 2nd review will come via security review by Asymmetric Research.
SC4RECOIN
added a commit
to m0-foundation/solana-m
that referenced
this pull request
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
initialize_multisigandrelease_inbound_mint_multisigixOption<'info, SplMultisig<'info>>account toInitializeandReleaseInboundMintstruct