ntt: sui implementation#613
Merged
emreboga merged 60 commits intowormhole-foundation:mainfrom Aug 21, 2025
Merged
Conversation
kcsongor
force-pushed
the
sui/implementation
branch
from
b9509ea to
3ff72c2
Compare
kcsongor
force-pushed
the
sui/implementation
branch
from
3ff72c2 to
799189e
Compare
kcsongor
force-pushed
the
sui/implementation
branch
from
799189e to
2c7680f
Compare
kcsongor
force-pushed
the
sui/implementation
branch
4 times, most recently
from
244d7b7 to
663e058
Compare
evan-gray
force-pushed
the
sui/implementation
branch
from
21ffdad to
3d64397
Compare
priyajeet
reviewed
Aug 20, 2025
priyajeet
reviewed
Aug 20, 2025
priyajeet
reviewed
Aug 20, 2025
priyajeet
reviewed
Aug 20, 2025
priyajeet
reviewed
Aug 20, 2025
priyajeet
reviewed
Aug 20, 2025
priyajeet
reviewed
Aug 20, 2025
priyajeet
reviewed
Aug 20, 2025
priyajeet
reviewed
Aug 20, 2025
gator-boi
previously approved these changes
Aug 20, 2025
Contributor
gator-boi
left a comment
gator-boi
left a comment
There was a problem hiding this comment.
It's been a couple of years since I have worked with Move/Sui, so I wouldn't put much weight on this review. However, I did review the general logic of the Move code and it's sound, and matches the NTT spec.
this needs to be Auth
payloads are supposed to be handled by modifying the ntt source code, instead of having the recipient handle it. because of this, we don't need to implemnent any additional protections in the default ntt instance
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
…29) * feat: Adding implementation for transfer status functions Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz> * Add redeem implementation Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz> * Fix tests Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz> --------- Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
…natures to match NTT interface Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
* Add ntt::release call to redeem flow Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz> * Fix tests Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz> --------- Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
* Move shared functionality to utils and constants Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz> * Fix unit tests Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz> --------- Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
* Implement setOwner Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz> * Remove extensive variable checks Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz> --------- Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
evan-gray
force-pushed
the
sui/implementation
branch
from
23b9334 to
897a6a8
Compare
added 2 commits
August 21, 2025 14:35
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
Signed-off-by: Emre Bogazliyanlioglu <emre@wormholelabs.xyz>
gator-boi
approved these changes
Aug 21, 2025
priyajeet
reviewed
Aug 21, 2025
priyajeet
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.