Merged
Conversation
nvsriram
reviewed
Jun 26, 2025
evgeniko
previously approved these changes
Jun 26, 2025
nik-suri
force-pushed
the
cli/solana-cli-version-check
branch
from
b4c93bb to
46499ec
Compare
This vastly improves the error message when the wrong solana-cli version is installed. Before this change, it just prints a cryptic file not found error. Also changed the `checkAnchorVersion` function to read the expected version from the Anchor.toml of the relevant worktree. This makes the function robust in the future in case future ntt versions are upgraded to newer anchor versions.
Co-authored-by: Sriram Nurani Viswanathan <50625504+nvsriram@users.noreply.github.com>
detect the appropriate version picker and run it
nvsriram
force-pushed
the
cli/solana-cli-version-check
branch
from
c14897f to
ea5471d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This vastly improves the error message when the wrong solana-cli version is installed. Before this change, it just prints a cryptic file not found error.
Also changed the
checkAnchorVersionfunction to read the expected version from the Anchor.toml of the relevant worktree. This makes the function robust in the future in case future ntt versions are upgraded to newer anchor versions.