Skip to content

cli: make set-mint-authority a top-level command with chain parameter support#657

Merged
evgeniko merged 5 commits intomainfrom
cli/set_mint_authority_top_level
Jul 21, 2025
Merged

cli: make set-mint-authority a top-level command with chain parameter support#657
evgeniko merged 5 commits intomainfrom
cli/set_mint_authority_top_level

Conversation

@evgeniko
Copy link
Copy Markdown
Contributor

@evgeniko evgeniko commented Jul 18, 2025

in preparation for other SVM chains being supported by the CLI. So far the default was Solana

Copy link
Copy Markdown
Contributor

@nvsriram nvsriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the set-mint-authority function only applies to SVM so I don't think it should be made top-level.

I'm not super familiar with Fogo tooling but seeing as the function itself does not have any major changes, I'll assume it has similar tooling. Is there a reason we want to move the set-mint-authority command up rather just rename the solana command to svm? Do some solana subcommands not apply to Fogo?

@kcsongor
Copy link
Copy Markdown
Contributor

I think the main benefit of doing this is so we can support other runtimes down the line other than SVM under the same command. It would be neat if we could set up a token on a new chain in a platform agnostic way (as far as the CLI interface is concerned). That said, this command should error for now if the platform is not SVM

@kcsongor
Copy link
Copy Markdown
Contributor

59b6e78 here's a branch I started which has some overlap, but should show the general direction

@evgeniko
Copy link
Copy Markdown
Contributor Author

I added the svm error. I would like to keep this PR separate from the branch you created @kcsongor, just to have less code to review.

Comment thread cli/src/index.ts Outdated
Co-authored-by: Sriram Nurani Viswanathan <50625504+nvsriram@users.noreply.github.com>
Comment thread cli/src/index.ts Outdated
Co-authored-by: Sriram Nurani Viswanathan <50625504+nvsriram@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@nvsriram nvsriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe as a consequence, the original helper function would also need to be renamed to checkSvmValidSplMultisig along with all other references of it in this file.

Copy link
Copy Markdown
Contributor

@nvsriram nvsriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aadam-10 aadam-10 requested a review from kcsongor July 21, 2025 15:17
@evgeniko evgeniko merged commit 2b736b6 into main Jul 21, 2025
9 checks passed
@evgeniko evgeniko deleted the cli/set_mint_authority_top_level branch July 21, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants