cli: add Solana Wormhole transceiver registration to the add-chain command#727
Merged
cli: add Solana Wormhole transceiver registration to the add-chain command#727
Conversation
evgeniko
changed the title
evgeniko
requested review from
kcsongor and
nvsriram
and removed request for
nvsriram
kcsongor
reviewed
Oct 30, 2025
… already has a try catch and doesn't rethrow
nvsriram
suggested changes
Oct 30, 2025
Contributor
nvsriram
left a comment
nvsriram
left a comment
There was a problem hiding this comment.
The changes look good but maybe they should be part of deploySolana where initialization happens. That way, we can avoid the chainToPlatform check and ntt, ctx typecasting.
nvsriram
approved these changes
Oct 30, 2025
kcsongor
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment the
add-chaincommand does not register a Wormhole transceiver for Solana. As a result, thentt statuscommand returns the following error, which is confusing:This PR moves the Solana transceiver registration into its own function and calls the function at the end of the add-chain command, achieving parity with the behaviour of other chains.
Resulting in
ntt statusnot showing the above error anymore.