solana: Add Cargo integration tests for standalone shim transceiver#728
Merged
solana: Add Cargo integration tests for standalone shim transceiver#728
Conversation
nvsriram
force-pushed
the
solana/add-shim-transceiver-cargo-tests
branch
from
f85c3e6 to
521559d
Compare
nvsriram
force-pushed
the
solana/add-shim-transceiver-cargo-tests
branch
from
86368b6 to
0e3eea6
Compare
johnsaigle
approved these changes
Nov 6, 2025
Collaborator
johnsaigle
left a comment
johnsaigle
left a comment
There was a problem hiding this comment.
I didn't review in detail, but this PR seems to be changing only tests, build files, and imports without major application changes.
nik-suri
approved these changes
Nov 6, 2025
Contributor
nik-suri
left a comment
nik-suri
left a comment
There was a problem hiding this comment.
LGTM with the context that:
- I'm not able to review the changes in depth
- The only changes to non-testing code simply re-order dependencies, no functional changes.
- All other changes only impact testing code
- A proper review of this testing code will be rolled into the security review process.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds:
testingfeature forntt-transceiverthat sets post message shim instruction data as return data. This is necessary because without an RPC running,simulateTransactiondoes not fill in the instruction data/logs — this acts as a testing workaround and should only be enabled for the Cargo integration tests.test-utilscrate that contains common test utilities, feature-gated sdks,.soprogram fixtures