cli: support deploying different EVM variants#750
Merged
Conversation
kcsongor
force-pushed
the
cli/deployment-flavours
branch
from
29d4f57 to
9702d09
Compare
evan-gray
previously approved these changes
Nov 20, 2025
evan-gray
previously approved these changes
Nov 25, 2025
kcsongor
force-pushed
the
cli/deployment-flavours
branch
2 times, most recently
from
7f1db9b to
6132fde
Compare
evan-gray
approved these changes
Nov 25, 2025
dvgui
approved these changes
Nov 26, 2025
We have a growing list of NTT manager variants (the standard, one without rate limiting, one that wraps WETH, and maybe we'll have more) To achieve this, we have to do a couple things. Firstly, we use deploy script in the worktree by default. The current (as in before this commit) method of overriding the deploy script with the one bundled into the cli was introduced at the very beginning to allow deploying versions that didn't have the updated deploy script available. This was actually already redundant by the time the first NTT release was cut. It's very rigid behaviour because it doesn't allow introducing breaking changes to the deploy script that don't work with older versions of the contract. So: we simply use the deploy script that's in the work tree. This allows us to evolve the deploy script over time, such as in the current case where we add support for the different variants. One problem is that prior to this commit, the deploy scripts at various version releases don't work (for example no currently released version supports non-0 wormhole fees.). So, if the deploy script in the worktree is old (doesn't contain the newly introduced DEPLOY_SCRIPT_VERSION comment), then we override it with a known version that works. Otherwise we just use the worktree version, which will work going forward.
so it can unwrap WETH
kcsongor
force-pushed
the
cli/deployment-flavours
branch
from
6132fde to
4a0e50a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a growing list of NTT manager variants (the standard, one without rate limiting, one that wraps WETH, and maybe we'll have more)
To achieve this, we have to do a couple things.
Firstly, we use deploy script in the worktree by default.
The current (as in before this commit) method of overriding the deploy script with the one bundled into the cli was introduced at the very beginning to allow deploying versions that didn't have the updated deploy script available. This was actually already redundant by the time the first NTT release was cut. It's very rigid behaviour because it doesn't allow introducing breaking changes to the deploy script that don't work with older versions of the contract.
So: we simply use the deploy script that's in the work tree.
This allows us to evolve the deploy script over time, such as in the current case where we add support for the different variants.
One problem is that prior to this commit, the deploy scripts at various version releases don't work (for example no currently released version supports non-0 wormhole fees.). So, if the deploy script in the worktree is old (doesn't contain the newly introduced DEPLOY_SCRIPT_VERSION comment), then we override it with a known version that works. Otherwise we just use the worktree version, which will work going forward.