Skip to content

cli: fix forge command RPC parsing & run prettier#767

Merged
evgeniko merged 16 commits intomainfrom
rpc_quotes
Dec 16, 2025
Merged

cli: fix forge command RPC parsing & run prettier#767
evgeniko merged 16 commits intomainfrom
rpc_quotes

Conversation

@evgeniko
Copy link
Copy Markdown
Contributor

@evgeniko evgeniko commented Dec 12, 2025

  • quote rpc urls to prevent forge commands to fail on rpc urls with special characters like "&"
  • run prettier for correct formatting
  • add prettier CI check

fergarrui
fergarrui previously approved these changes Dec 12, 2025
dvgui
dvgui previously approved these changes Dec 15, 2025
nvsriram
nvsriram previously approved these changes Dec 16, 2025
Copy link
Copy Markdown
Contributor

@nvsriram nvsriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left some nits.

Comment thread .github/workflows/prettier.yml
Comment thread .github/workflows/prettier.yml Outdated
@evgeniko evgeniko dismissed stale reviews from nvsriram and dvgui via 099328e December 16, 2025 12:19
@evgeniko evgeniko merged commit d3065e6 into main Dec 16, 2025
10 of 11 checks passed
@evgeniko evgeniko deleted the rpc_quotes branch December 16, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants