Deploy files as lvuser not admin#740
Open
spacey-sooty wants to merge 2 commits intowpilibsuite:mainfrom
Open
Conversation
Contributor
|
How did you test this? At a minimum I don't think it will work unless the roborio was freshly imaged. And I suspect there are some things that need to be admin. |
Member
|
Yeah this absolutely will not work. If you look at the c++ file deploy you’ll see we change the owner of the deployed file to lvuser. The same thing would need to happen to the deploy folder. |
Contributor
Author
|
Should I make a custom artifact type to handle this? |
Member
|
This definitely won't work. getFiles() is a file tree, and toString() on that is definitely not correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #408