Clarify that Enable Desktop Support switch is CPP only#835
Clarify that Enable Desktop Support switch is CPP only#835cswilson252 wants to merge 32 commits intowpilibsuite:2027from
Conversation
|
As the 2026.1.1 release is out, we're not going to make any changes to the gradle templates for 2026. Please change this to target the 2027 branch. |
done, just fixing conflicts |
Add a message for Manage Vendor Libraries Partially addresses wpilibsuite/2026Beta#1
Include vendordeps and build.gradle and full source directory to make it easier to restore from roboRIO jar. Fixes wpilibsuite/GradleRIO#713
a8167cd to
8ddad19
Compare
|
ok, i've somehow deleted all of my own commits during what was supposed to be a rebase. that's what i get for using |
ah, I pushed from a detached HEAD, and not a branch. At least it makes everything easy to restore :) |
|
done! |
|
When I try to create a C++ project, it doesn't let me select the Enable Desktop Support checkbox. It also doesn't show a tooltip or anything |
|
:( |
This should be fixed now! :) |
I still see the same behavior |
|
I also noticed that if I went back and changed the project type, the checkbox was not re-enabled |
Co-authored-by: sciencewhiz <sciencewhiz@users.noreply.github.com>
Gold856
left a comment
There was a problem hiding this comment.
Please test your changes before requesting another review.
| }); | ||
|
|
||
| validateStep2(); | ||
| const desktopCb = document.getElementById('desktopCB') as HTMLInputElement; | ||
| desktopCb.addEventListener('change', () => { | ||
| if (languageSelect.value !== 'cpp') { | ||
| desktopCb.disabled = true; | ||
| desktopCb.title = 'Desktop Support can only be enabled for C++ projects!'; | ||
| } else if (languageSelect.value == 'cpp') { | ||
| validateStep2(); | ||
| } |
There was a problem hiding this comment.
Checkbox event listener is the wrong way to do this, go back to the language event listener. And the branch still isn't updated. You need to reenable the checkbox when it's C++.
|
YASPR (Yet Another Shambolic Pull Request) 😭 |
Closes #800