Add workaround for default attn_type#578
Merged
feifeibear merged 1 commit intoxdit-project:mainfrom Oct 21, 2025
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds a workaround for allowing the default
attn_typeto beAttnType.FAfor legacy reasons while still being able to run xDiT withoutyunchanginstalled.Why?
As discussed in the issue #576 , for example Wan2.1 repo no longer works out-of-the-box with the xDiT, as it assumes the default value for
attn_typeto beAttnType.FA, which has been set toNoneby PR #559 .How?
We set the default
attn_typewithin init call itself, not as the default value. This keeps the support for Apple Silicon without interfering with legacy default values.@feifeibear