Add support for NV Sage attention#670
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for Sage Attention, providing a new high-performance attention backend option. The changes involve integrating Sage Attention into the core attention mechanism, ensuring proper environment detection, and validating its availability during runtime. This enhancement allows users to leverage Sage Attention for potentially improved performance, as demonstrated by the provided benchmark results, and maintains system stability through robust compatibility checks. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for the NV Sage attention backend. The changes are well-implemented, covering the addition of the new backend type, the registration of its attention function, and environment checks to ensure the necessary package is installed. I have one minor suggestion to make the environment check more robust by specifying the exception being caught.
What?
Adds support for NV Sage attention
Tests
Run command:
wan2.2_t2v_u1r1_tc_False_720x1280_0.1.mp4
Time: 917s (1 GPU)
Run command:
wan2.2_t2v_u1r1_tc_False_720x1280_0.mp4
Time: 885s (1 GPU)