CI: add lockfile update action to manually trigger for dependabot PRs#3647
Merged
superlopuh merged 1 commit intomainfrom Dec 16, 2024
Merged
CI: add lockfile update action to manually trigger for dependabot PRs#3647superlopuh merged 1 commit intomainfrom
superlopuh merged 1 commit intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3647 +/- ##
==========================================
- Coverage 90.75% 90.75% -0.01%
==========================================
Files 467 467
Lines 58905 58905
Branches 5639 5639
==========================================
- Hits 53460 53458 -2
- Misses 4001 4002 +1
- Partials 1444 1445 +1 ☔ View full report in Codecov by Sentry. |
alexarice
reviewed
Dec 16, 2024
Collaborator
alexarice
left a comment
There was a problem hiding this comment.
So this needs to be manually run on dependabot prs?
Member
Author
|
For now, yes |
jorendumoulin
approved these changes
Dec 16, 2024
Member
Author
|
Stop-gap until this beast is merged: dependabot/dependabot-core#10040 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tested it here and it works if you do the dumb thing and trigger on push, but it seems to not run actions on unsigned commits by default. I'm hoping that if we trigger the action manually it'll inherit the clicker's permissions and re-run the action. In either case, I think whatever we adopt should supercede the cron job one as we want to never be out of sync between the pyproject and lockfile.