fix(find_qt): gracefully handle unsupported -qtconf argument#6528
Merged
Conversation
waruqi
reviewed
Jun 6, 2025
| local envs = {} | ||
| local run_args = {"-query"} | ||
| if sdkdir then | ||
| local qmake_help = os.iorunv(qmake, {"-help"}) |
Member
There was a problem hiding this comment.
if qmake not found or no qt env, os.iorunv will break.
waruqi
reviewed
Jun 6, 2025
| if os.isfile(conf_path) then | ||
| table.join2(run_args, {"-qtconf", conf_path}) | ||
| break | ||
| local qmake_help = try {function () return os.iorunv(qmake, {"-help"}) end} |
Member
There was a problem hiding this comment.
这会导致每次查找，qmake 都会被执行两次，影响性能。
应该是直接尝试带 -qtconf 执行，如果执行成功，也就一次，对于不常碰到的低版本，执行 -qtconf 失败，继续 fallback 执行第二次。
Doekin
changed the title
-qtconf argument support before passing to qmake-qtconf argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.