Fixes #47 (again): Support plural items on max occurs on sequence elements#97
Merged
xuri merged 3 commits intoxuri:masterfrom Aug 4, 2025
Merged
Conversation
xuri
added a commit
to xuri/xsd
that referenced
this pull request
Aug 4, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 81.58% 81.77% +0.19%
==========================================
Files 36 37 +1
Lines 1835 1855 +20
==========================================
+ Hits 1497 1517 +20
Misses 246 246
Partials 92 92
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xuri
approved these changes
Aug 4, 2025
Owner
xuri
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
#47 was not completely fixed in 8c60951
It still does not create slice types for sequences with
maxOccurs="unbound"(DatumItem *DatumItem xml:"datumItem"in the issue)Related Issue
#47
Motivation and Context
We have such an .xsd at work
How Has This Been Tested
Unit tests added
Types of changes
Checklist