Skip to content

Fixes #47 (again): Support plural items on max occurs on sequence elements#97

Merged
xuri merged 3 commits intoxuri:masterfrom
trifork:47-maxOccurs-on-sequences
Aug 4, 2025
Merged

Fixes #47 (again): Support plural items on max occurs on sequence elements#97
xuri merged 3 commits intoxuri:masterfrom
trifork:47-maxOccurs-on-sequences

Conversation

@wiegell
Copy link
Contributor

@wiegell wiegell commented Jul 31, 2025

PR Details

#47 was not completely fixed in 8c60951
It still does not create slice types for sequences with maxOccurs="unbound" (DatumItem *DatumItem xml:"datumItem" in the issue)

Related Issue

#47

Motivation and Context

We have such an .xsd at work

How Has This Been Tested

Unit tests added

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wiegell wiegell marked this pull request as draft July 31, 2025 09:24
@wiegell wiegell changed the title 47 max occurs on sequences Support plural items on max occurs on sequence elements Jul 31, 2025
@wiegell wiegell marked this pull request as ready for review July 31, 2025 12:56
@wiegell wiegell changed the title Support plural items on max occurs on sequence elements Fixes #47 (again): Support plural items on max occurs on sequence elements Jul 31, 2025
xuri added a commit to xuri/xsd that referenced this pull request Aug 4, 2025
@xuri xuri added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 4, 2025
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.77%. Comparing base (d9d0ba0) to head (609167f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   81.58%   81.77%   +0.19%     
==========================================
  Files          36       37       +1     
  Lines        1835     1855      +20     
==========================================
+ Hits         1497     1517      +20     
  Misses        246      246              
  Partials       92       92              
Flag Coverage Δ
unittests 81.77% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit aee1e76 into xuri:master Aug 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants