Fixes #98: Add support and test for element with equal type and name#99
Open
wiegell wants to merge 1 commit intoxuri:masterfrom
Open
Fixes #98: Add support and test for element with equal type and name#99wiegell wants to merge 1 commit intoxuri:masterfrom
wiegell wants to merge 1 commit intoxuri:masterfrom
Conversation
wiegell
changed the title
wiegell
changed the title
wiegell
changed the title
xuri
added
the
size/S
xuri
added a commit
to xuri/xsd
that referenced
this pull request
Aug 7, 2025
xuri
added a commit
to xuri/xsd
that referenced
this pull request
Aug 8, 2025
xuri
requested changes
Aug 8, 2025
| @@ -1,4 +1,7 @@ | |||
| <schema xmlns="http://www.w3.org/2001/XMLSchema" xmlns:here="http://example.org/" targetNamespace="http://example.org/"> | |||
| <schema xmlns="http://www.w3.org/2001/XMLSchema" xmlns:here="http://example.org/" | |||
Owner
There was a problem hiding this comment.
Please update expected generation code of this xsd for other supported languages to fix unit tests build break.
| if _, ok := gen.StructAST[v.Name]; !ok { | ||
| // If v.Name == v.Type generating a type alias will reference itself | ||
| // and result in a duplicate type definition error from the go compiler | ||
| if _, ok := gen.StructAST[v.Name]; !ok && v.Name != v.Type { |
Owner
There was a problem hiding this comment.
Do we need add this check for other languages generator?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Fixes #98 for go generation
I have debugged the code and the proto tree seems to be generated fine. The problem lies in the following code generation.
Description
Related Issue
#98
Motivation and Context
We have an .xsd at work that suffers from this issue
How Has This Been Tested
A test has been made that passes for the go generation, but i would like some advice on how/if this issue should be fixed for the other languages supported
Types of changes
Checklist