Fix potentiel script name conflicts #812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Travis failing on PHP 7.0 and WP 3.9 :) |
Contributor
|
Thanks for the PR @stayallive. It's almost there. Can you please remove the |
Contributor
Author
|
Dang, don't know how that sneaked in, excuse me :) It's gone now. |
lukecarbis
pushed a commit
that referenced
this pull request
Dec 21, 2015
Fix potentiel script name conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on PR #806 it would be better to rename the select2 and other third party libs to have a prefix to prevent the loading of scripts from another plugin.