Skip to content

Mods can have multiple Ocean and Coast Terrains#14630

Open
Ambeco wants to merge 2 commits intoyairm210:masterfrom
Ambeco:moddableCoasts
Open

Mods can have multiple Ocean and Coast Terrains#14630
Ambeco wants to merge 2 commits intoyairm210:masterfrom
Ambeco:moddableCoasts

Conversation

@Ambeco
Copy link
Contributor

@Ambeco Ambeco commented Mar 6, 2026

Coasts have CoastalOcean Unique. This allows for mods to have multiple custom Oceans, and multiple custom Coasts.

I made a temporary "New Ocean" thats from temps -1 to 0.5, and normal ocean from -.5 to 1. And also made "New Coast" thats from temps -1 to 0.5 and normal Coast from -.5 to 1. The "fade" looks reasonable, and there's no unexpected terrains or features occuring. https://photos.google.com/share/AF1QipPBTF5CRWh-055eSNRnPHkQAsyMWX_yupEqemG3EC9Pb03SQEOXwVFiAhw1qrCnCg/photo/AF1QipPtnavF6qtW-7dFWpBsQTbDlI2ccBWNs6CsJDao?key=c3ljME1hbmJZRFY5WkRyUU9raTZHcHdaZFJTTXRR

Signed-off-by: MPD mooing_psycho_duck@hotmail.com

@yairm210
Copy link
Owner

yairm210 commented Mar 6, 2026

What the hell is 'coastal ocean'? That's a contradiction in terms
The term you want is probably 'coastal water' or something similar

@Ambeco
Copy link
Contributor Author

Ambeco commented Mar 6, 2026

I'd started with isCoastal, but then discovered that Tile already has a member+field named isCoastal that returns true for LAND tiles adjacent to Coast terrains.
What I'll probably do is rename the unique to isCoastalWater, and rename Tile.isCoastal to be Tile.IsSeaside.

@github-actions
Copy link

github-actions bot commented Mar 7, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Coasts have CoastalOcean Unique. This allows for mods to have multiple custom Oceans, and multiple custom Coasts.

I made a temporary "New Ocean" thats from temps -1 to 0.5, and normal ocean from -.5 to 1. And also made "New Coast" thats from temps -1 to 0.5 and normal Coast from -.5 to 1.  The "fade" looks reasonable, and there's no unexpected terrains or features occuring. https://photos.google.com/share/AF1QipPBTF5CRWh-055eSNRnPHkQAsyMWX_yupEqemG3EC9Pb03SQEOXwVFiAhw1qrCnCg/photo/AF1QipPtnavF6qtW-7dFWpBsQTbDlI2ccBWNs6CsJDao?key=c3ljME1hbmJZRFY5WkRyUU9raTZHcHdaZFJTTXRR

Signed-off-by: MPD <mooing_psycho_duck@hotmail.com>
@github-actions
Copy link

github-actions bot commented Mar 8, 2026

Conflicts have been resolved.

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Conflicts label Mar 9, 2026
@github-actions
Copy link

github-actions bot commented Mar 9, 2026

Conflicts have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants