Forced unit disbandment considers refundability and promotions#14660
Open
unciv-loof wants to merge 2 commits intoyairm210:masterfrom
Open
Forced unit disbandment considers refundability and promotions#14660unciv-loof wants to merge 2 commits intoyairm210:masterfrom
unciv-loof wants to merge 2 commits intoyairm210:masterfrom
Conversation
unciv-loof
changed the title
yairm210
approved these changes
Mar 10, 2026
Owner
yairm210
left a comment
yairm210
left a comment
There was a problem hiding this comment.
Looks good, definitely better than current
Collaborator
|
Didn't we intentionally leave that dumb, maybe even after Civ5 dll source review? |
Owner
|
I don't think "intentionally dumb" is ever a good decision, even if we did make that call I'm overriding it now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you run significant gold deficits, the system will forcibly disband your units until the budget is back in balance.
Currently the units are chosen randomly, whereas an intelligent player would probably start by selling units with refund value (ones not outside your territory), and try to preserve highly promoted units. This PR attempts to replicate that thought process.
Based on poll.