PnP: Fix watch mode for files required under PnP#7077
Open
PnP: Fix watch mode for files required under PnP#7077
required under PnP#7077Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When running under
node --watch, the PnP hook only reports not-found virtual modules to the watching process, causing found virtual modules to not be watched.Fixes (partially) #6871
How did you fix it?
Report found modules from the PnP hook to the watching process.
Note that this does not fix watch mode for
imported modules, which remains broken for node 18.19+. Given that the ESM loader API hasn't stabilized I am hesitant to make any changes at this moment.Checklist