Skip to content

Document nightly builds on download page#245

Merged
Daniel15 merged 3 commits intoyarnpkg:masterfrom
Daniel15:nightly-upd
Nov 11, 2016
Merged

Document nightly builds on download page#245
Daniel15 merged 3 commits intoyarnpkg:masterfrom
Daniel15:nightly-upd

Conversation

@Daniel15
Copy link
Copy Markdown
Member

@Daniel15 Daniel15 commented Nov 4, 2016

References yarnpkg/yarn#1474

@Daniel15 Daniel15 changed the title Add documentation for nightly builds Document nightly builds on download page Nov 4, 2016
@Daniel15 Daniel15 mentioned this pull request Nov 4, 2016
10 tasks
{% capture windows %}{% include_relative _installations/windows.md %}{% endcapture %}
{% capture linux %}{% include_relative _installations/linux.md %}{% endcapture %}
{% capture alternatives %}{% include_relative _installations/alternatives.md %}{% endcapture %}
{% capture nightly %}{% include_relative _installations/nightly.md %}{% endcapture %}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should emphasize nightly builds so much? I feel like we should make it a separate thing

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like a totally separate page? It seemed to fit in nicely here and I imagine this is where people would look for the info, I can put it elsewhere if you like though!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't need to be a separate page, but maybe it's own section on the same page. I don't know how well "nightly" is going to translate and I don't want people installing it because they weren't able to use one of the other options

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it a separate section initially, but the page seemed pretty long. I'll try that again soon 👍

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm imagining a separate box that explains what nightly is that can be expanded to include instructions

./install.sh --nightly
```

A Ubuntu/Debian repository of the nightly builds is also available. To enable it, run the following commands:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A Ubuntu 👉 An Ubuntu

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I can change that!

@Daniel15
Copy link
Copy Markdown
Member Author

@thejameskyle - Are there any other changes you'd like, or is this good to merge now (apart from changing "a Ubuntu" to "an Ubuntu")?

@Daniel15
Copy link
Copy Markdown
Member Author

Going to merge this and iterate (and/or ask for forgiveness) if we don't like this approach.

@Daniel15 Daniel15 merged commit 87f87d2 into yarnpkg:master Nov 11, 2016
@Daniel15 Daniel15 deleted the nightly-upd branch November 11, 2016 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants