Conversation
- Eliminated `python-jose` from the dependencies list in both `pyproject.toml` and `uv.lock` to streamline package management and reduce unnecessary dependencies.
- Added `JWT_PREVIOUS_SECRET_KEY` and `JWT_PREVIOUS_PUBLIC_KEY` to `AuthXConfig` for key rotation. - Implemented fallback logic in token verification methods to use the previous public key if the current key fails. - Introduced WebSocket authentication handling with token verification, supporting both query parameters and headers.
- Introduced a new test suite in `test_key_rotation.py` to validate JWT signing key rotation functionality for both symmetric and asymmetric keys. - Implemented tests for token creation and decoding with current and previous keys, ensuring proper fallback behavior and error handling. - Added configuration property tests for `previous_public_key` in `AuthXConfig` to verify correct retrieval of previous keys.
- Introduced a new test suite in `test_websocket.py` to validate WebSocket authentication using JWT tokens. - Implemented tests for token retrieval from query parameters and authorization headers, including scenarios for missing, invalid, and revoked tokens. - Added support for custom query parameter names and token scopes in the authentication process.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Modified the type hint for the `headers` parameter in the `_ws` function to use `Optional` for better clarity and to handle potential None values. - Adjusted the import statement to include `Optional` from the typing module.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
- Coverage 98.83% 98.54% -0.29%
==========================================
Files 16 16
Lines 856 894 +38
Branches 90 99 +9
==========================================
+ Hits 846 881 +35
- Misses 5 7 +2
- Partials 5 6 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Removed the use of `MutableHeaders` and `Headers` from the request setup in `test_key_rotation.py` and `test_authx_extend.py`. - Introduced a new helper function `_make_request` to streamline request creation with authorization headers. - Updated tests to utilize the new request creation method, improving code clarity and maintainability.
- Moved RSA and EC key pair generation functions to `tests/utils.py` for better reusability. - Updated `test_asymmetric.py` and `test_key_rotation.py` to utilize the new key pair generation functions, improving code clarity and maintainability.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.