Skip to content

Fix #319: Improve confirmation style#324

Merged
samdark merged 5 commits intomasterfrom
319-better-confirm
Feb 22, 2026
Merged

Fix #319: Improve confirmation style#324
samdark merged 5 commits intomasterfrom
319-better-confirm

Conversation

@samdark
Copy link
Copy Markdown
Member

@samdark samdark commented Feb 22, 2026

Q A
Is bugfix?
New feature?
Breaks BC?

Copilot AI review requested due to automatic review settings February 22, 2026 15:05
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.68%. Comparing base (72ea2cf) to head (878b23a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #324      +/-   ##
============================================
- Coverage     99.69%   99.68%   -0.01%     
+ Complexity      296      293       -3     
============================================
  Files            20       20              
  Lines           976      952      -24     
============================================
- Hits            973      949      -24     
  Misses            3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the confirmation prompt mechanism in migration commands by replacing the manual QuestionHelper/ConfirmationQuestion approach with SymfonyStyle's built-in confirm() method. While the PR title references issue #319 (which is about removing confirmation from the create command), this PR actually improves the confirmation style in three migration commands: UpdateCommand, RedoCommand, and DownCommand.

Changes:

  • Replaced custom confirm() private methods with inline SymfonyStyle confirm() calls
  • Removed unused imports for QuestionHelper and ConfirmationQuestion
  • Simplified confirmation logic while maintaining the same behavior (respects --force-yes option)

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/Command/UpdateCommand.php Removed private confirm() method and replaced with SymfonyStyle's confirm() for applying migrations
src/Command/RedoCommand.php Removed private confirm() method and replaced with SymfonyStyle's confirm() for redoing migrations
src/Command/DownCommand.php Removed private confirm() method and replaced with SymfonyStyle's confirm() for reverting migrations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 22, 2026

@samdark I've opened a new pull request, #325, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
@samdark samdark merged commit 09e4caf into master Feb 22, 2026
51 checks passed
@samdark samdark deleted the 319-better-confirm branch February 22, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants