Conversation
samdark
commented
Feb 22, 2026
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #324 +/- ##
============================================
- Coverage 99.69% 99.68% -0.01%
+ Complexity 296 293 -3
============================================
Files 20 20
Lines 976 952 -24
============================================
- Hits 973 949 -24
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This pull request refactors the confirmation prompt mechanism in migration commands by replacing the manual QuestionHelper/ConfirmationQuestion approach with SymfonyStyle's built-in confirm() method. While the PR title references issue #319 (which is about removing confirmation from the create command), this PR actually improves the confirmation style in three migration commands: UpdateCommand, RedoCommand, and DownCommand.
Changes:
- Replaced custom
confirm()private methods with inline SymfonyStyleconfirm()calls - Removed unused imports for QuestionHelper and ConfirmationQuestion
- Simplified confirmation logic while maintaining the same behavior (respects --force-yes option)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Command/UpdateCommand.php | Removed private confirm() method and replaced with SymfonyStyle's confirm() for applying migrations |
| src/Command/RedoCommand.php | Removed private confirm() method and replaced with SymfonyStyle's confirm() for redoing migrations |
| src/Command/DownCommand.php | Removed private confirm() method and replaced with SymfonyStyle's confirm() for reverting migrations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>