Conversation
Member
rustamwin
commented
Aug 20, 2025
rustamwin
commented
| Q | A |
|---|---|
| Is bugfix? | ✔️/❌ |
| New feature? | ✔️/❌ |
| Breaks BC? | ✔️/❌ |
| Fixed issues | yiisoft/db#94 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #422 +/- ##
=========================================
Coverage 98.67% 98.67%
- Complexity 248 250 +2
=========================================
Files 24 24
Lines 753 757 +4
=========================================
+ Hits 743 747 +4
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tigrov
requested changes
Aug 20, 2025
Member
Tigrov
left a comment
Tigrov
left a comment
There was a problem hiding this comment.
MySQL does not support FROM clause in UPDATE query. It should generate UPDATE table1, table2, ... query instead
Tigrov
reviewed
Aug 22, 2025
# Conflicts: # tests/Provider/QueryBuilderProvider.php
Tigrov
reviewed
Sep 5, 2025
src/DMLQueryBuilder.php
Outdated
Comment on lines
+72
to
+74
| /** | ||
| * MySQL does not support UPDATE ... FROM ... | ||
| */ |
Member
There was a problem hiding this comment.
It supports using another syntax
UPDATE table_name, table_from SET table_name.field=table_from.field
Added exceptions in Oracle, MySQL, and SQL Server query builders to explicitly throw errors if the FROM clause is used in an UPDATE statement. This ensures clarity and avoids unexpected behavior in unsupported scenarios.
vjik
approved these changes
Sep 10, 2025
Tigrov
approved these changes
Sep 21, 2025
Member
Tigrov
left a comment
Tigrov
left a comment
There was a problem hiding this comment.
After merge, needs to add an issue to implement it using this syntax
UPDATE table_name, table_from SET table_name.field=table_from.field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.