Skip to content

impr(quotes): add 10 English quotes (@yohaann196)#1

Merged
yohaann196 merged 5 commits intomasterfrom
copilot/add-10-new-quotes
Mar 13, 2026
Merged

impr(quotes): add 10 English quotes (@yohaann196)#1
yohaann196 merged 5 commits intomasterfrom
copilot/add-10-new-quotes

Conversation

Copy link

Copilot AI commented Mar 13, 2026

Description

Adds 10 English literary/inspirational quotes (IDs 7753–7762). Fixes two issues with the initial submission:

  • Unicode escapes: JSON was serialized with ensure_ascii=True, causing \u2019 (right single quote '), \u2014 (em dash ), \u00e9 (é), etc. to appear as escape sequences. Re-serialized with ensure_ascii=False — 84 total fixes across the file.
  • Short quote: ID 7759 was 52 chars ("May your choices reflect your hopes, not your fears."). Replaced with a unique 79-char quote verified against the full dataset.

New quotes:

ID Text Source
7753 It was the best of times, it was the worst of times, it was the age of wisdom, it was the age of foolishness. A Tale of Two Cities
7754 It is our choices, Harry, that show what we truly are, far more than our abilities. Harry Potter and the Chamber of Secrets
7755 I am no bird; and no net ensnares me: I am a free human being with an independent will. Jane Eyre
7756 The most important things are the hardest to say. They are the things you get ashamed of, because words diminish them. The Body
7757 I took a deep breath and listened to the old brag of my heart: I am, I am, I am. The Bell Jar
7758 Two roads diverged in a wood, and I took the one less traveled by, and that has made all the difference. The Road Not Taken
7759 The world breaks everyone, and afterward, some are strong at the broken places. A Farewell to Arms
7760 So we beat on, boats against the current, borne back ceaselessly into the past. Old sport. The Great Gatsby
7761 One must always be careful of books, and what is inside them, for words have the power to change us. Clockwork Angel
7762 There is no greater agony than bearing an untold story inside you. I Know Why the Caged Bird Sings

All quotes are ≥60 characters and verified unique against the full dataset.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?
    • Make sure to follow the languages documentation
    • Add language to packages/schemas/src/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?
    • Make sure to follow the themes documentation
    • Add theme to packages/schemas/src/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • (optional) Add theme css file to frontend/static/themes
    • Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request
  • Adding a layout?
    • Make sure to follow the layouts documentation
    • Add layout to packages/schemas/src/layouts.ts
    • Add layout json file to frontend/static/layouts
  • Adding a font?
    • Make sure to follow the fonts documentation
    • Add font file to frontend/static/webfonts
    • Add font to packages/schemas/src/fonts.ts
    • Add font to frontend/src/ts/constants/fonts.ts
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

Co-authored-by: yohaann196 <229655281+yohaann196@users.noreply.github.com>
Copilot AI changed the title [WIP] Add 10 English quotes to the collection fix(quotes): replace duplicate quotes and fix JSON formatting (@yohaann196) Mar 13, 2026
Copilot AI requested a review from yohaann196 March 13, 2026 02:42
…quote

Co-authored-by: yohaann196 <229655281+yohaann196@users.noreply.github.com>
Copilot AI changed the title fix(quotes): replace duplicate quotes and fix JSON formatting (@yohaann196) impr(quotes): add 10 English quotes (@yohaann196) Mar 13, 2026
…quotes 60+ chars

Co-authored-by: yohaann196 <229655281+yohaann196@users.noreply.github.com>
@yohaann196 yohaann196 marked this pull request as ready for review March 13, 2026 03:02
… install side effects)

Co-authored-by: yohaann196 <229655281+yohaann196@users.noreply.github.com>
@yohaann196 yohaann196 merged commit 19b63c1 into master Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants