fix: enhance protolint_flags option#4
Conversation
* Resolved argument handling in protolint_flags option * Uses .protolint.yaml if present * Updated README.md Closes yoheimuta#3
|
I tested it locally with act and it works as expected. |
yoheimuta
left a comment
yoheimuta
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
You're correct that ${INPUT_PROTOLINT_FLAGS} shouldn't have been enclosed in double quotations.
And I've posted a minor question.
README.md
Outdated
| [](https://github.com/haya14busa/action-bumpr) | ||
|
|
||
| This GitHub Action runs [protolint](https://github.com/yoheimuta/protolint) with [reviewdog](https://github.com/reviewdog/reviewdog). | ||
| By default, action-protolint uses the `.protolint.yaml` configuration file if it exists. |
There was a problem hiding this comment.
I assume that protolint would work in that manner, so action-protolint shouldn't need to specify the .protolint.yaml file located in the current working directory. Have you confirmed whether protolint failed to locate that file?
protolint will automatically search a current working directory for the config file by default and successive parent directories all the way up to the root directory of the filesystem. And it can search the specified directory with -config_dir_path flag. It can also search the specified file with --config_path flag.
https://github.com/yoheimuta/protolint#configuring
There was a problem hiding this comment.
It looks like the problem might be related to the quotes around ${INPUT_PROTOLINT_FLAGS}. I removed the code to check the existence of the .protolint.yaml config file, protolint can still find the config file.
|
🚀 [bumpr] Bumped! New version:v1.1.0 Changes:v1.0.0...v1.1.0 |
2 participants
Closes #3