-
Notifications
You must be signed in to change notification settings - Fork 1k
Description
- I have read and understood docs/Issues.md.
Describe the bug
EdgeOS Model does not remove secret value when command set system config-management commit-archive location is set in config. Per Commit Revisions and Archival section in EdgeRouter - Archiving and Managing the Configuration Files, you can set a destination as an scp, ftp or tftp URI with scp and ftp URI's containing passwords in the URI. eg: scp://<user>:<passwd>@<host>/<dir> or ftp://<user>:<passwd>@<host>/<dir>
To Reproduce
Steps to reproduce the behavior:
- Configure backup of any device using EdgeOS where
set system config-management commit-archive locationis set - Use model 'edgeos'
- Run 'backup'
- See that
set system config-management commit-archive locationcontains full URI with password. eg:set system config-management commit-archive location 'scp://myusername:myplaintextpassword@hostmame/dir/'
Expected behavior
That either the full URI at least the password would be substituted with <secret removed>.
Configuration
I don't think its applicable
Logs
I don't think its applicable
Running environment (please complete the following information):
- OS: Ubuntu Jammy as LXC OS
- oxidized version: [e.g. 0.30.1] - but model is the same
- oxidized-web version:
- Manufacturer model an software version: EdgeRouterX 2.0.9-hotfix.7
- oxidized model name: edgeos
Additional context
I think this is a bug in the context of an oversight and not a feature request, but it may be on the edge between the two.
I'm not sure if Vyatta supports commit-archive location but if it does then it may also need the same fix.