Vyos removes non-secret after "community" in route-map rule

[einsibjarni]

• I have read and understood docs/Issues.md.

Describe the bug
This is part of our config:

set policy route-map export-isnic rule 10 set community add '1234:1234'

But oxidized stores it as:

set policy route-map export-isnic rule 10 set community <secret removed> '1234:1234'

It's because snmp communities are considered private and the rule to strip them is very naive.

To Reproduce
Add this config to a vyos router:

set policy route-map export-isnic rule 10 set community add '1234:1234'

Expected behavior
The oxidized stored config includes:

set policy route-map export-isnic rule 10 set community add '1234:1234'

Configuration

Logs

Running environment (please complete the following information):

Additional context

[einsibjarni]

oxidized/lib/oxidized/model/vyatta.rb

Line 17 in f5f75ce

cfg.gsub! /community (\S+)/, 'community <hidden>'

Maybe replace with: cfg.gsub! /service snmp community (\S+)/, 'service snmp community <hidden>'?

[systeembeheerder]

@einsibjarni better use the new VyOS model and not the old vyatta

[einsibjarni]

@einsibjarni better use the new VyOS model and not the old vyatta

Sorry, made a mistake when I linked to the source. I am using the vyos model, and the problem is there too:

oxidized/lib/oxidized/model/vyos.rb

Line 18 in f5f75ce

cfg.gsub! /community (\S+)/, 'community <secret removed>'