Skip to content

[LenovoNOS] Remove lines that always change#3305

Merged
robertcheramy merged 4 commits intoytti:masterfrom
Kani999:lenovonos_remove_unnecessary_lines
Nov 3, 2024
Merged

[LenovoNOS] Remove lines that always change#3305
robertcheramy merged 4 commits intoytti:masterfrom
Kani999:lenovonos_remove_unnecessary_lines

Conversation

@Kani999
Copy link
Contributor

@Kani999 Kani999 commented Oct 31, 2024

Pre-Request Checklist

  • Passes rubocop code analysis (try rubocop --auto-correct)
  • Tests added or adapted (try rake test)
  • Changes are reflected in the documentation
  • User-visible changes appended to CHANGELOG.md

Description

  • Removes lines that started with Fan because RPM always changes. Example of removed lines:
! Fan 3 in Module 2: RPM= 8194 PWM= 25 ( 9%) Back-To-Front [J]
! Fan 4 in Module 2: RPM= 3884 PWM= 25 ( 9%) Back-To-Front [J]
! Fan 5 in Module 3: RPM= 7976 PWM= 90 ( 9%) Back-To-Front [N]
  • Salt administrator-password line when remove_unstable_lines is set to True. Example:
access user administrator-password <unstable line hidden>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants