Add support for Moxa (industrial switches)#3359
Closed
Marc-79 wants to merge 2 commits intoytti:masterfrom
Closed
Conversation
add support for Moxa devices (industrial switches)
add moxa support
| # Tested on EDS EDS-510E (v5.5), EDS-408A-SS-SC V3.13 | ||
| # Default login must be turn to shell : 1 Basic Settings, Login mode, Toggle login mode) | ||
|
|
||
| prompt prompt /.*#/ |
Collaborator
There was a problem hiding this comment.
Please use a more specific prompt regexp. Matching .*# will randomly match on contents of your config and you will experience unexpected timeouts.
Collaborator
|
Please also consider providing a Device simulation file https://github.com/ytti/oxidized/blob/master/docs/DeviceSimulation.md to help us maintain the model in the future. |
Collaborator
|
And the CI tests must pass. |
|
This PR is stale because it has been open 90 days with no activity. |
Collaborator
|
PR closed as no reaction from the submitter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Hi, unfortunatly i'm not an ruby expert and was not able to run the tests, the model work for me (under local models) in a docker container.
Sorry to not be able to do all required tests.