Further Improvements to password masking in powerconnect.rb from #1212#3405
Merged
robertcheramy merged 5 commits intoytti:masterfrom Feb 19, 2025
Merged
Conversation
…#1212 In both the 3400 and 6200 series the previous regex would miss the following passwords: password 123456789abcdef0123456789abcdef0 encrypted enable password 123456789abcdef0123456789abcdef0 encrypted
powerconnect: Hide enable, and line secrets
powerconnect: Hide enable, and line secrets. Further Fixes ytti#1212 (#clifcox)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In both the 3400 and 6200 series the previous regex would miss the following passwords:
password 123456789abcdef0123456789abcdef0 encrypted
enable password 123456789abcdef0123456789abcdef0 encrypted
This update changes the output From:
To:
It is a bit odd that Dell would choose to insert "level ##" in between password, and <secret>, but here is an example from a 3448:
enable password level 15 123456789abcdef0123456789abcdef0 encryptedPre-Request Checklist
rubocop --auto-correct)rake test)Description
Further improvements to #1212 and PR:
Skip the word 'encrypted' in Powerconnect password masking #1227