ironware model: graceful handling of N-digit temps, addition of simulated ironware:ICX7150-48Z-HPOE (Ruckus) yaml

[merelissdgr]

Pre-Request Checklist

• Passes rubocop code analysis (try rubocop --auto-correct)
• Tests added or adapted (try rake test)
• Changes are reflected in the documentation
• User-visible changes appended to CHANGELOG.md

Description

Add substitution for 3-digit temps to match 2-digit masking so as not to create unnecessary config commits when temps cross the 100 deg-C boundary in either direction between polls.

[merelissdgr]

rubocop-sequel extension supports plugin, specify `plugins: rubocop-sequel` instead of `require: rubocop-sequel` in /Users/merelis/repos/oxidized/.rubocop.yml.
For more information, see https://docs.rubocop.org/rubocop/plugin_migration_guide.html.

Inspecting 182 files
......................................................................................................................................................................................

182 files inspected, no offenses detected```

[merelissdgr]

Please let me know if you require anything further from me to get this merged. Happy to help. Thanks.

[robertcheramy]

Notes:

• If you provide a Device simulation file, it will be easier to test if the change works correctly.
• Don't worry about the rubocop-sequel extension, this has to be fixed separately.

[robertcheramy]

This could be better be solved by modifying the Line 40 and use \d+ or \d{2,3}

[merelissdgr]

Agreed. I originally had it like the latter and it upset something in the PR automated workflow related to linting. That's the only reason I submitted it this way in this attempt, but I've gone ahead and modified it once again as I agree it's better.

[merelissdgr]

I've added the simulation yaml file and modified/reverted the regex to the more simplified/generalized solution.

Let me know if there's anything else I can do, thanks.

[robertcheramy]

I've tuned the yaml simulation file because the post_login and pre_logout commands where missing and added a unit test.

If the "fake" answers in the simulation file are OK for you, I would merge this PR. If you want to change them to something more real, please do so, and I'll merge after it.

Note that these answers don't have an impact on the output of the model, so it is okay to leave them unchanged.

[merelissdgr]

All seems good to me, thank you.

[merelissdgr]

LGTM