fabricos: remove input voltage from chassisShow#3510
Merged
robertcheramy merged 1 commit intoytti:masterfrom Jun 26, 2025
Merged
fabricos: remove input voltage from chassisShow#3510robertcheramy merged 1 commit intoytti:masterfrom
robertcheramy merged 1 commit intoytti:masterfrom
Conversation
hops
force-pushed
the
fabricos-chassisshow
branch
from
734fee4 to
195e328
Compare
Contributor
Author
|
I've resolved the conflicts by rebasing my branch. Please let me know if I can assist in any way to get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Some Brocade Fibre Channel switches report the power supply input voltage in the output of
chassisShow. This pull request removes lines containingPS Voltage inputbecause voltage fluctuations are unavoidable and would cause unnecessary backup changes.This is an example line from a Brocade G630:
PS Voltage input: 231.00 VI didn't run the tests or rubocop butI built the docker image with this change and tested it against the actual device.