#366 Fix(http): Prevent duplication when handling pagination#3655
Merged
robertcheramy merged 4 commits intoytti:masterfrom Nov 30, 2025
Merged
#366 Fix(http): Prevent duplication when handling pagination#3655robertcheramy merged 4 commits intoytti:masterfrom
robertcheramy merged 4 commits intoytti:masterfrom
Conversation
Collaborator
|
The CI failing on ruby-head is OK - it has been fixed on master. |
Collaborator
|
Note - I transferred issue from oxidized-web to oxidized, it now has the ID #3676. |
Contributor
Author
|
Changelog has been updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-Request Checklist
rubocop --auto-correct)rake test)Description
Fixed loop logic that held onto data on subsequent paginated runs, resulting in duplicated nodes. This was likely to occur with Netbox and large inventory >1000 nodes, beyond the default
MAX_PAGE_SIZEof 1000 when utilizinglimit=1000with the Netbox source. For example, if you had 1200 nodes and were pulling batches of 1000, you would end up with 1400 nodes because 1000-1200 were duped. Behavior is as described in a bug report over in theoxidized-webproject for #3676 but wasnt related tooxidized-webdirectly so I am correcting it here.Should close issue in
oxidized-web#3676